About thumbnails

Mareks

If I want to put thumbnails for unknown files. How to set this thumbnail img so it gallery knows?

Karl

Mareks If I want to put thumbnails for unknown files. How to set this thumbnail img so it gallery knows?

Sorry this is not possible yet. I will be considering it for a future release. Keep in mind, if you add a custom image to an unknown file type, it will not be able to open the file on user click. This could be confusing.

If I do add it, it will work like this: A file somefile.ext will look for JPG image _files_somefile.ext.jpg as thumb. It needs to start with _files so that Files Gallery knows that the custom thumbnail should not be visible in the gallery.

Mareks

Your thumbnail idea is ok. Let me define onclick="randomFunction" for specific file type too. So when I want to open up and make custom html and js actions. If not, just open default preview screen to download file.

Karl

Mareks Let me define onclick="randomFunction" for specific file type too. So when I want to open up and make custom html and js actions.

It's a bit clumsy to create custom functions on a per filetype basis. However, maybe there could be some custom itemClick function, where you could add your own functionality before the default click events are assigned.

_c.config = {
  itemClick: function(item){
    if(['ext1', 'ext2'].includes(item.ext)) { // for example check the extension of the clicked item
      someCustomFunction(item); // trigger your own function
      return false; // tell Files Gallery to stop processing clicks on this item, as we are doing our own thing
    }
    return true; // tell Files Gallery to process clicks as usual
  }
}

Mareks

Karl This is what I want. I better make JS mods and avoid editing php, to make files.gallery updates painless.

Karl

Mareks I better make JS mods and avoid editing php, to make files.gallery updates painless.

Yes. Almost all application logic is done in Javascript anyway, so it wouldn't be possible to customize this in PHP.

Mareks

I tested itemClick and it never gets triggered. Where exacly it should trigger it?
I would want to catch click and add my custom preview inside [id="modal_preview"]

Karl

Mareks I tested itemClick and it never gets triggered. Where exacly it should trigger it?

I never said this is a working solution. I said this is something I could consider implementing in a future release:

Mareks I would want to catch click and add my custom preview inside [id="modal_preview"]

I'm not sure what you mean by this. If you want to catch clicks, you would need to add your own click handler in javascript, that detects if the click is inside the modal. This is not a part of Files Gallery. About "custom preview", if I add this feature, then yes it will get loaded into modal by default also.

Mareks

Karl I already made it. Basically onload checks for item file type and (if exists) shows custom thumbnail. When you click on any item, it checks type and will call specific js function that will add custum iframe etc to preview modal.

It works fine, but I would want elegant way to make custom previews for unknown file types.

Now I use observers to catch any changes. To have native files.gallery event callbacks would be amazing. Mby you can update new release that I can give some feedbacks.

Even for existing jpg I change img to svg in preview modal, because I have specific needs. Let me interact with preview modal for any file (if necessary)

Mareks

Does new release will include this?

Karl

Mareks Does new release will include this?

No sorry it's not. This requires more thoughts and planning. My concepts above was just a quick idea of how it might work if something like this was ever to be integrated.

Mareks

Karl This is major feature, because than everyone can share and be able to open specific file types. Ofc its more thoughtful, because php comes in to the game.

Karl

Mareks This is major feature, because than everyone can share and be able to open specific file types. Ofc its more thoughtful, because php comes in to the game.

I have already noted the feature request. However, I don't know what you mean "everyone can share and be able to open specific file types". Files Gallery already supports all file types. How will you use this feature to support file types that Files Gallery does not support?

Mareks Ofc its more thoughtful, because php comes in to the game.

As my example stated, it's javascript, not PHP. PHP can't control this in any way.

Mareks

Karl

They can generate custom thumbnails and preview modal. And these small code "plugins" everyone can apply and try out.
PHP comes in to the game, when you upload file. Same as how image/pdf thumbnails got generated. Most of my custom previews got generated by php exec.

Karl

Mareks They can generate custom thumbnails and preview modal. And these small code "plugins" everyone can apply and try out.

Yes custom thumbnails will be implemented at some point.
However, I don't see what that has to do with "small code plugins everyone can apply and try out"

Mareks PHP comes in to the game, when you upload file. Same as how image/pdf thumbnails got generated. Most of my custom previews got generated by php exec.

Sorry, but I'm not sure what we are talking about here. If we implement custom thumbnails, it will attempt to load something like _files_filename.ext.jpg from the current directory. I don't see how this has anything to do with PDF thumbnails or anything in PHP exec.

Mareks

Karl

I just ment share in forum code snippets etc.
Imagine, as example, if you have file type ".3dmodel", I check this file type at upload and generate thumbnail image from specific program (exec) and than I put this thumbnail image insade built in files.gallery thumbnails folder. Than files.gallery check if it exists, than it shows. For sure files.gallery check if thumbnail exists (files_filename.ext.jpg). Your idea is perfect but php has to do some job too, if needed.

P.S. Sorry, I ment thumbnails not previews.

Karl

Mareks Imagine, as example, if you have file type ".3dmodel", I check this file type at upload and generate thumbnail image from specific program (exec) and than I put this thumbnail image insade built in files.gallery thumbnails folder. Than files.gallery check if it exists, than it shows. For sure files.gallery check if thumbnail exists (files_filename.ext.jpg). Your idea is perfect but php has to do some job too, if needed.

PHP will of course need to check if the custom thumbnail exists, so that the application can load the custom thumbnail. There won't be anything else that PHP does, because the point of this option, is to be able to create thumbnails manually for file types that otherwise don't display a thumbnail.