Bugs with opening current folder info

sev

Found some issues during testing:

Opening the current dir info without having seen any files results in list.matchingItems being unset. open_modal doesn't check if it exists and tries to see if the dir is inside list.matchingItems. This causes an error and prevents the modal from opening.
Opening the current dir info modal with an image in the last position in the file list will result in that image showing up in the modal and overflowing the thumbnail div. Since the current dir is not included in the list.matchingItems array, the matchingItems.findIndex returns -1, and the code later gets the last item in the array when using that index which happens to be an image, instead of the actual dir data. There may be more issues associated with this behavior, but this is just what I found.

Karl

sev Opening the current dir info without having seen any files results in list.matchingItems being unset.

This isn't useful. I don't even know what that means. Files Gallery certainly does not "unset" anything. Do you mean when someone clicks the contextmenu dropdown button on the right for the current dir, before the dir is loaded? If so, then please explain. There is no other way to "opening the current dir info".

sev Opening the current dir info modal with an image in the last position in the file list will result in that image showing up in the modal and overflowing the thumbnail div. Since the current dir is not included in the list.matchingItems array, the matchingItems.findIndex returns -1, and the code later gets the last item in the array when using that index which happens to be an image, instead of the actual dir data. There may be more issues associated with this behavior, but this is just what I found.

Sorry, it doesn't make sense. Why not provide a link? Unbelievable. A modal will NEVER open if the item is not found in matchingItems. This looks like some badly implemented customization.

Karl

sev These two issues have been fixed in latest release Files Gallery 0.10.0.

sev

Karl Do you mean when someone clicks the contextmenu dropdown button on the right for the current dir

Yes. Here is me doing it:

https://i.imgur.com/1KUbF3A.mp4

Karl A modal will NEVER open if the item is not found in matchingItems

It is easy to reproduce. Set $root to point to an empty folder and do what I did, or right click the background and select "Show info" from there. Then check the console. I can reproduce on the latest version of Files Gallery with latest Firefox and Chrome.

Karl Sorry, it doesn't make sense.

So I took a moment and looked into why the second issue really occurs. It's true that the image is returned for the folder preview, but that's actually intentional, I misunderstood the codepath. It is minified after all, I did my best. Here's what I found.

The JS does not add the <a class="modal-preview-a"> element to the folder preview image if the file is missing the url_path value, and the var that fits the image into the preview div is set using that class. The url_path value is not sent over in the body <script> element if the file is outside of document root, which can happen in a supported configuration by simply setting your root to somewhere outside of docroot. (In that case, Files Gallery proxies the file, and it should be fine if url_path is empty.)

Karl Why not provide a link?

I've emailed you two test links that reproduce these issues.

Karl This looks like some badly implemented customization.

The test links do not have any customizations or changes to index.php, the JS, or anything else...

Regards.

Karl

I got your email, and can confirm that there is a bug when trying to get folder info for current dir if current dir is empty. I wish you could explain easier like "If current dir is empty, show info for current dir does not work". That's all that would be required!

As for your 2nd error, I can't reproduce it. Here is from your own link, working as it should:

How can it be that difficult to explain? Just show me a link that gets an error. Why you have a screenshot in this post, and then can't include that error in a link?

sev

Karl Here is from your own link, working as it should:

No, use "Show info" on the directory. The modal when clicking the file does work as it should.

Karl I wish you could explain easier like "If current dir is empty, show info for current dir does not work". That's all that would be required!

But that isn't the issue. It only occurs when the current loaded dir is empty, before navigating to any other directory. Navigating away fixes the issue as the array has been assigned. If the issue was that simple I would have explained it like that.

When I see an issue, I do my best to thoroughly understand it, and when I share that with someone else, I do my best to thoroughly explain it and provide as much detail as possible. I am doing the best I can, I am not psychic and I can't see how you will understand something... So I don't know what else I can do to help the situation.

Karl Why you have a screenshot in this post, and then can't include that error in a link?

Because I thought that would be enough to understand the issue.

Karl

sev No, use "Show info" on the directory. The modal when clicking the file does work as it should.

This is something different though. The modal does display. There is some bug because you are pointing config root to some folder with files that are outside the servers document_root. I will look into it.

sev But that isn't the issue. It only occurs when the current loaded dir is empty, before navigating to any other directory. Navigating away fixes the issue as the array has been assigned. If the issue was that simple I would have explained it like that.

True. I will look into it.

It just isn't helpful for you to share screenshots of un-minified code and speak of properties being "unset". The problem isn't that list.matchingItems gets "unset" (it never does) ... The problem is that the list plugin itself isn't triggered yet, so list.matchingItems will be undefined.

sev When I see an issue, I do my best to thoroughly understand it, and when I share that with someone else, I do my best to thoroughly explain it and provide as much detail as possible. I am doing the best I can, I am not psychic and I can't see how you will understand something... So I don't know what else I can do to help the situation.

Thanks for reporting! For me, it would be better if you could just either 1. send a link, or 2 include basic instructions on how to reproduce the issue.

I will solve both issues in next maintenance release in a few weeks.

sev

Karl The problem isn't that list.matchingItems gets "unset" (it never does)

Sorry, I should have said undefined. I am not very well versed in JS. I meant unset as in "it hasn't been set yet".

Thanks for looking into this.

Karl

sev It's already fixed in new release, which should be out in 1-2 weeks.